no-return-wrap.js
1.31 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
/**
* Rule: no-return-wrap function
* Prevents uneccessary wrapping of results in Promise.resolve
* or Promise.reject as the Promise will do that for us
*/
'use strict'
var isPromise = require('./lib/is-promise')
var rejectMessage = 'Expected throw instead of Promise.reject'
var resolveMessage = 'Avoid wrapping return values in Promise.resolve'
function isInPromise (context) {
var expression = context.getAncestors().filter(function (node) {
return node.type === 'ExpressionStatement'
})[0]
return expression && expression.expression && isPromise(expression.expression)
}
module.exports = {
create: function (context) {
return {
ReturnStatement: function (node) {
if (isInPromise(context)) {
if (node.argument) {
if (node.argument.type === 'CallExpression') {
if (node.argument.callee.type === 'MemberExpression') {
if (node.argument.callee.object.name === 'Promise') {
if (node.argument.callee.property.name === 'resolve') {
context.report(node, resolveMessage)
} else if (node.argument.callee.property.name === 'reject') {
context.report(node, rejectMessage)
}
}
}
}
}
}
}
}
}
}